Skip to content

Commit fd368f0

Browse files
committed
Merge pull request #695 from ken0nek/master
Use "is None" and add space after comma
2 parents c486a3a + bdef272 commit fd368f0

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

stdlib/public/common/MirrorCommon.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,23 @@
1414
# If you edit this, make sure to also accordingly tweak the actual template files.
1515

1616
def getDisposition(disp=None):
17-
if disp == None:
17+
if disp is None:
1818
return '.Aggregate'
1919
if len(disp) == 0 or disp[0] != '.':
2020
disp = '.' + disp
2121
return disp
2222

23-
def _getGenericArgStrings(genericArgs=None,genericConstraints=None):
24-
if genericArgs == None:
23+
def _getGenericArgStrings(genericArgs=None, genericConstraints=None):
24+
if genericArgs is None:
2525
return ('','')
2626
genericArgString = ''
2727
first = True
2828
for arg in genericArgs:
2929
if not first:
30-
genericArgString = genericArgString + ','
30+
genericArgString = genericArgString + ','
3131
first = False
3232
genericArgString = genericArgString + arg
33-
if genericConstraints == None:
33+
if genericConstraints is None:
3434
genericConstraintString = genericArgString
3535
else:
3636
genericConstraintString = ''
@@ -45,11 +45,11 @@ def _getGenericArgStrings(genericArgs=None,genericConstraints=None):
4545
genericConstraintString = genericConstraintString + ' : ' + cons
4646
genericArgString = '<' + genericArgString + '>'
4747
genericConstraintString = '<' + genericConstraintString + '>'
48-
return (genericArgString,genericConstraintString)
48+
return (genericArgString, genericConstraintString)
4949

50-
def getGenericArgString(genericArgs=None,genericConstraints=None):
51-
return _getGenericArgStrings(genericArgs,genericConstraints)[0]
50+
def getGenericArgString(genericArgs=None, genericConstraints=None):
51+
return _getGenericArgStrings(genericArgs, genericConstraints)[0]
5252

53-
def getGenericConstraintString(genericArgs=None,genericConstraints=None):
54-
return _getGenericArgStrings(genericArgs,genericConstraints)[1]
53+
def getGenericConstraintString(genericArgs=None, genericConstraints=None):
54+
return _getGenericArgStrings(genericArgs, genericConstraints)[1]
5555

utils/cmpcodesize/cmpcodesize/compare.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242

4343

4444
def addFunction(sizes, function, startAddr, endAddr, groupByPrefix):
45-
if not function or startAddr == None or endAddr == None:
45+
if not function or startAddr is None or endAddr is None:
4646
return
4747

4848
size = endAddr - startAddr
@@ -113,7 +113,7 @@ def readSizes(sizes, fileName, functionDetails, groupByPrefix):
113113
asmlineMatch = asmlinePattern.match(line)
114114
if asmlineMatch:
115115
addr = int(asmlineMatch.group(1), 16)
116-
if startAddr == None:
116+
if startAddr is None:
117117
startAddr = addr
118118
endAddr = addr
119119
elif line == "Section":
@@ -142,7 +142,7 @@ def readSizes(sizes, fileName, functionDetails, groupByPrefix):
142142
def compareSizes(oldSizes, newSizes, nameKey, title):
143143
oldSize = oldSizes[nameKey]
144144
newSize = newSizes[nameKey]
145-
if oldSize != None and newSize != None:
145+
if oldSize is not None and newSize is not None:
146146
if oldSize != 0:
147147
perc = "%.1f%%" % ((1.0 - float(newSize) / float(oldSize)) * 100.0)
148148
else:

0 commit comments

Comments
 (0)