Merge pull request #16160 from slavapestov/typo-correction-tweak

Add typo correction test case that was fixed, and skip accessors in lookup

Author: slavapestov

lib/AST/LookupVisibleDecls.cpp

@@ -124,6 +124,10 @@ static bool areTypeDeclsVisibleInLookupMode(LookupState LS) {
 static bool isDeclVisibleInLookupMode(ValueDecl *Member, LookupState LS,
                                       const DeclContext *FromContext,
                                       LazyResolver *TypeResolver) {
+  // Accessors are never visible directly in the source language.
+  if (isa<AccessorDecl>(Member))
+    return false;
+
   if (TypeResolver) {
     TypeResolver->resolveDeclSignature(Member);
     TypeResolver->resolveAccessControl(Member);

test/Sema/typo_correction.swift

@@ -144,3 +144,15 @@ func test_overloaded() {
   overloadd(0)
   // expected-error@-1 {{use of unresolved identifier 'overloadd'; did you mean 'overloaded'?}}{{3-12=overloaded}}
 }
+
+// This is one of the backtraces from rdar://36434823 but got fixed along
+// the way.
+class CircularValidationWithTypo {
+  var cdcdcdcd = ababab { // expected-error {{use of unresolved identifier 'ababab'}}
+    didSet { }
+  }
+
+  var abababab = cdcdcdc { // expected-error {{use of unresolved identifier 'cdcdcdc'}}
+    didSet { }
+  }
+}