Skip to content

Commit fdceacc

Browse files
committed
---
yaml --- r: 346103 b: refs/heads/master c: abb9c07 h: refs/heads/master i: 346101: 8165088 346099: f3bcf93 346095: a1de698
1 parent 14792f2 commit fdceacc

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 116d53cf88e9a71f011568b5680ef26e36fd814d
2+
refs/heads/master: abb9c07936667077006dcbc5492a8fe2fb3cc70a
33
refs/heads/master-next: 203b3026584ecad859eb328b2e12490099409cd5
44
refs/tags/osx-passed: b6b74147ef8a386f532cf9357a1bde006e552c54
55
refs/tags/swift-2.2-SNAPSHOT-2015-12-01-a: 6bb18e013c2284f2b45f5f84f2df2887dc0f7dea

trunk/stdlib/private/SwiftPrivateThreadExtras/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ add_swift_target_library(swiftSwiftPrivateThreadExtras ${SWIFT_STDLIB_LIBRARY_BU
1212
SWIFT_MODULE_DEPENDS_FREEBSD Glibc
1313
SWIFT_MODULE_DEPENDS_CYGWIN Glibc
1414
SWIFT_MODULE_DEPENDS_HAIKU Glibc
15-
SWIFT_MODULE_DEPENDS_WINDOWS MSVCRT
15+
SWIFT_MODULE_DEPENDS_WINDOWS MSVCRT WinSDK
1616
SWIFT_COMPILE_FLAGS
1717
INSTALL_IN_COMPONENT stdlib-experimental)
1818

trunk/stdlib/private/SwiftPrivateThreadExtras/SwiftPrivateThreadExtras.swift

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,10 +116,8 @@ public func _stdlib_thread_join<Result>(
116116
_ resultType: Result.Type
117117
) -> (CInt, Result?) {
118118
#if os(Windows)
119-
// TODO(compnerd) modularize rpc.h for INFINITE (0xffffffff)
120-
let result = WaitForSingleObject(thread, 0xffffffff);
121-
// TODO(compnerd) modularize WinBase.h for WAIT_OBJECT_0 (0)
122-
if result == 0 {
119+
let result = WaitForSingleObject(thread, INFINITE)
120+
if result == WAIT_OBJECT_0 {
123121
var threadResult: DWORD = 0
124122
GetExitCodeThread(thread, &threadResult)
125123
CloseHandle(thread)

trunk/stdlib/private/SwiftPrivateThreadExtras/ThreadBarriers.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,8 @@ public func _stdlib_thread_barrier_wait(
122122
if barrier.pointee.numThreadsWaiting < barrier.pointee.count {
123123
// Put the thread to sleep.
124124
#if os(Windows)
125-
// TODO(compnerd) modularize rpc.h to get INFIITE (0xffffffff)
126125
if SleepConditionVariableSRW(barrier.pointee.cond!, barrier.pointee.mutex!,
127-
0xffffffff, 0) == 0 {
126+
INFINITE, 0) == 0 {
128127
return -1
129128
}
130129
ReleaseSRWLockExclusive(barrier.pointee.mutex!)

0 commit comments

Comments
 (0)