Merge pull request #28606 from DougGregor/function-builders-pound-diag

Author: swift-ci

lib/Sema/BuilderTransform.cpp

@@ -163,6 +163,12 @@ class BuilderClosureVisitor
         if (isa<IfConfigDecl>(decl))
           continue;
 
+        // Emit #warning/#error but don't build anything for it.
+        if (auto poundDiag = dyn_cast<PoundDiagnosticDecl>(decl)) {
+          TypeChecker::typeCheckDecl(poundDiag);
+          continue;
+        }
+
         if (!unhandledNode)
           unhandledNode = decl;
 

test/Constraints/function_builder_diags.swift

@@ -225,3 +225,12 @@ func extraArg() {
     6 // expected-error {{extra argument in call}}
   }
 }
+
+// rdar://problem/53209000 - use of #warning and #error
+tuplify(true) { x in
+  1
+  #error("boom")    // expected-error{{boom}}
+  "hello"
+  #warning("oops")  // expected-warning{{oops}}
+  3.14159
+}