ASTGen: Translate import declarations

Author: AnthonyLatsis

include/swift/AST/CASTBridging.h

@@ -264,12 +264,6 @@ void Diagnostic_finish(BridgedDiagnostic cDiag);
 BridgedIdentifier ASTContext_getIdentifier(BridgedASTContext cContext,
                                            BridgedString cStr);
 
-void *ImportDecl_create(BridgedASTContext cContext,
-                        BridgedDeclContext cDeclContext,
-                        BridgedSourceLoc cImportLoc, char kind,
-                        BridgedSourceLoc cKindLoc, BridgedArrayRef path,
-                        BridgedArrayRef cPathLocs);
-
 void *TopLevelCodeDecl_createStmt(BridgedASTContext cContext,
                                   BridgedDeclContext cDeclContext,
                                   BridgedSourceLoc cStartLoc, void *element,
@@ -494,6 +488,25 @@ void *OperatorDecl_create(
     BridgedIdentifier cPrecedenceGroupName,
     BridgedSourceLoc cPrecedenceGroupLoc);
 
+typedef enum ENUM_EXTENSIBILITY_ATTR(open) {
+  BridgedImportKindModule,
+  BridgedImportKindType,
+  BridgedImportKindStruct,
+  BridgedImportKindClass,
+  BridgedImportKindEnum,
+  BridgedImportKindProtocol,
+  BridgedImportKindVar,
+  BridgedImportKindFunc,
+} BridgedImportKind;
+
+void *ImportDecl_create(
+    BridgedASTContext cContext,
+    BridgedDeclContext cDeclContext,
+    BridgedSourceLoc cImportKeywordLoc,
+    BridgedImportKind cImportKind,
+    BridgedSourceLoc cImportKindLoc,
+    BridgedArrayRef cImportPathElements);
+
 void *GenericParamList_create(
     BridgedASTContext cContext,
     BridgedSourceLoc cLeftAngleLoc,

lib/AST/CASTBridging.cpp

@@ -173,29 +173,6 @@ BridgedIdentifier ASTContext_getIdentifier(BridgedASTContext cContext,
   return {convertASTContext(cContext).getIdentifier(str).getAsOpaquePointer()};
 }
 
-void *ImportDecl_create(BridgedASTContext cContext,
-                        BridgedDeclContext cDeclContext,
-                        BridgedSourceLoc cImportLoc, char kind,
-                        BridgedSourceLoc cKindLoc, BridgedArrayRef path,
-                        BridgedArrayRef cPathLocs) {
-  assert(path.numElements == cPathLocs.numElements);
-  ASTContext &context = convertASTContext(cContext);
-  DeclContext *declContext = convertDeclContext(cDeclContext);
-
-  ImportPath::Builder importPath;
-  for (auto p : llvm::zip(convertArrayRef<Identifier>(path),
-                          convertArrayRef<SourceLoc>(cPathLocs))) {
-    Identifier ident;
-    SourceLoc loc;
-    std::tie(ident, loc) = p;
-    importPath.push_back(ident, loc);
-  }
-  return ImportDecl::create(context, declContext, convertSourceLoc(cImportLoc),
-                            static_cast<ImportKind>(kind),
-                            convertSourceLoc(cKindLoc),
-                            std::move(importPath).get());
-}
-
 BridgedSourceLoc SourceLoc_advanced(BridgedSourceLoc cLoc, long len) {
   SourceLoc loc = convertSourceLoc(cLoc).getAdvancedLoc(len);
   return {loc.getOpaquePointerValue()};
@@ -898,6 +875,33 @@ void *OperatorDecl_create(
   return static_cast<Decl *>(decl);
 }
 
+void *ImportDecl_create(
+    BridgedASTContext cContext,
+    BridgedDeclContext cDeclContext,
+    BridgedSourceLoc cImportKeywordLoc,
+    BridgedImportKind cImportKind,
+    BridgedSourceLoc cImportKindLoc,
+    BridgedArrayRef cImportPathElements) {
+
+  ImportPath::Builder builder;
+  for (auto &element :
+       convertArrayRef<BridgedIdentifierAndSourceLoc>(cImportPathElements)) {
+    builder.push_back(
+        convertIdentifier(element.name), convertSourceLoc(element.nameLoc));
+  }
+
+  ASTContext &context = convertASTContext(cContext);
+  auto *decl = ImportDecl::create(
+      context,
+      convertDeclContext(cDeclContext),
+      convertSourceLoc(cImportKeywordLoc),
+      static_cast<ImportKind>(cImportKind),
+      convertSourceLoc(cImportKindLoc),
+      std::move(builder).get());
+
+  return static_cast<Decl *>(decl);
+}
+
 void *OptionalTypeRepr_create(BridgedASTContext cContext, void *base,
                               BridgedSourceLoc cQuestionLoc) {
   ASTContext &context = convertASTContext(cContext);

lib/ASTGen/Sources/ASTGen/Decls.swift

@@ -377,3 +377,47 @@ extension ASTGenVisitor {
     )
   }
 }
+
+// MARK: - ImportDecl
+
+extension BridgedImportKind {
+  fileprivate init(tokenKind: TokenKind) {
+    switch tokenKind {
+    case .keyword(.typealias): self = .type
+    case .keyword(.struct): self = .struct
+    case .keyword(.class): self = .class
+    case .keyword(.enum): self = .enum
+    case .keyword(.protocol): self = .protocol
+    case .keyword(.var), .keyword(.let): self = .var
+    case .keyword(.func): self = .func
+    default: fatalError("Unknown import kind")
+    }
+  }
+}
+
+extension ASTGenVisitor {
+  public func visit(_ node: ImportDeclSyntax) -> ASTNode {
+    let importKind: BridgedImportKind
+    if let tokenKind = node.importKind?.tokenKind {
+      importKind = BridgedImportKind(tokenKind: tokenKind)
+    } else {
+      importKind = .module
+    }
+
+    return .decl(
+      node.path.map { component in
+        let (name, nameLoc) = self.bridgedIdentifierAndSourceLoc(for: component.name)
+        return BridgedIdentifierAndSourceLoc(name: name, nameLoc: nameLoc)
+      } withBridgedArrayRef: { importPath in
+        ImportDecl_create(
+          self.ctx,
+          self.declContext,
+          self.bridgedSourceLoc(for: node.importKeyword),
+          importKind,
+          self.bridgedSourceLoc(for: node.importKind),
+          importPath
+        )
+      }
+    )
+  }
+}

test/ASTGen/verify-parse.swift

@@ -14,6 +14,16 @@
 
 // NB: Ridiculous formatting to test that we do not include leading trivia in locations.
 
+import
+Swift
+import typealias Swift.Codable
+import enum Swift.Optional
+import struct Swift.Array
+import class Swift.KeyPath
+import protocol Swift.Sequence
+import func Swift.max
+import var Swift._playgroundPrintHook
+
 func
 test1
 (