Skip to content

Commit ff73bb8

Browse files
committed
change test according to review comments
1 parent 5623dd9 commit ff73bb8

File tree

1 file changed

+34
-18
lines changed

1 file changed

+34
-18
lines changed

test/SourceKit/InterfaceGen/gen_swift_module.swift

Lines changed: 34 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,39 +44,55 @@ func f(s : inout [Int]) {
4444
// CHECK-DECLARATIONS-ARRAY: {{^}}]{{$}}
4545

4646
// public class MyClass
47-
// CHECK-DECLARATIONS-ARRAY: key.kind:{{.*}}class
48-
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr
49-
// CHECK-DECLARATIONS-ARRAY-SAME: swift_mod
50-
// CHECK-DECLARATIONS-ARRAY-SAME: MyClass
47+
// CHECK-DECLARATIONS-ARRAY: key.kind:
48+
// CHECK-DECLARATIONS-ARRAY-SAME: decl
49+
// CHECK-DECLARATIONS-ARRAY-SAME: class
50+
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr:
51+
// could check for parts of the usr, but as the .response files always check for exact matches, do the same here
52+
// CHECK-DECLARATIONS-ARRAY-SAME: s:9swift_mod7MyClassC
53+
// check that offsets are there, but not zero, as that might mean offsets are broken (none of the declaration offsets in this file should be zero)
54+
// CHECK-DECLARATIONS-ARRAY-NOT: key.offset:{{.*}}{{^[0-9]}}0{{^[0-9]}}
55+
// CHECK-DECLARATIONS-ARRAY: key.offset
5156

5257
// public func pub_method
53-
// CHECK-DECLARATIONS-ARRAY: key.kind:{{.*}}method.instance
54-
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr
55-
// CHECK-DECLARATIONS-ARRAY-SAME: swift_mod
56-
// CHECK-DECLARATIONS-ARRAY-SAME: MyClass
57-
// CHECK-DECLARATIONS-ARRAY-SAME: pub_method
58+
// CHECK-DECLARATIONS-ARRAY: key.kind:
59+
// CHECK-DECLARATIONS-ARRAY-SAME: decl
60+
// CHECK-DECLARATIONS-ARRAY-SAME: method.instance
61+
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr:
62+
// CHECK-DECLARATIONS-ARRAY-SAME: s:9swift_mod7MyClassC10pub_methodyyF
63+
// CHECK-DECLARATIONS-ARRAY-NOT: key.offset:{{.*}}{{^[0-9]}}0{{^[0-9]}}
64+
// CHECK-DECLARATIONS-ARRAY: key.offset
5865

5966
// CHECK-DECLARATIONS-ARRAY-NOT: int_method
6067
// CHECK-DECLARATIONS-ARRAY-NOT: fp_method
6168
// CHECK-DECLARATIONS-ARRAY-NOT: priv_method
6269

6370
// public protocol MyProto
64-
// CHECK-DECLARATIONS-ARRAY: key.kind:{{.*}}protocol
71+
// CHECK-DECLARATIONS-ARRAY: key.kind:
72+
// CHECK-DECLARATIONS-ARRAY-SAME: decl
73+
// CHECK-DECLARATIONS-ARRAY-SAME: protocol
6574
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr
66-
// CHECK-DECLARATIONS-ARRAY-SAME: swift_mod
67-
// CHECK-DECLARATIONS-ARRAY-SAME: MyProto
75+
// CHECK-DECLARATIONS-ARRAY-SAME: s:9swift_mod7MyProtoP
76+
// CHECK-DECLARATIONS-ARRAY-NOT: key.offset:{{.*}}{{^[0-9]}}0{{^[0-9]}}
77+
// CHECK-DECLARATIONS-ARRAY: key.offset
6878

6979
// associatedtype Assoc
70-
// CHECK-DECLARATIONS-ARRAY: key.kind:{{.*}}associatedtype
80+
// CHECK-DECLARATIONS-ARRAY: key.kind:
81+
// CHECK-DECLARATIONS-ARRAY-SAME: decl
82+
// CHECK-DECLARATIONS-ARRAY-SAME: associatedtype
7183
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr
72-
// CHECK-DECLARATIONS-ARRAY-SAME: swift_mod
73-
// CHECK-DECLARATIONS-ARRAY-SAME: Assoc
84+
// CHECK-DECLARATIONS-ARRAY-SAME: s:9swift_mod7MyProtoP5AssocQa
85+
// CHECK-DECLARATIONS-ARRAY-NOT: key.offset:{{.*}}{{^[0-9]}}0{{^[0-9]}}
86+
// CHECK-DECLARATIONS-ARRAY: key.offset
7487

7588
// public func pub_function
76-
// CHECK-DECLARATIONS-ARRAY: key.kind:{{.*}}function.free
89+
// CHECK-DECLARATIONS-ARRAY: key.kind:
90+
// CHECK-DECLARATIONS-ARRAY-SAME: decl
91+
// CHECK-DECLARATIONS-ARRAY-SAME: function.free
7792
// CHECK-DECLARATIONS-ARRAY-NEXT: key.usr
78-
// CHECK-DECLARATIONS-ARRAY-SAME: swift_mod
79-
// CHECK-DECLARATIONS-ARRAY-SAME: pub_function
93+
// CHECK-DECLARATIONS-ARRAY-SAME: s:9swift_mod12pub_functionSiyF
94+
// CHECK-DECLARATIONS-ARRAY-NOT: key.offset:{{.*}}{{^[0-9]}}0{{^[0-9]}}
95+
// CHECK-DECLARATIONS-ARRAY: key.offset
8096

8197
// CHECK-DECLARATIONS-ARRAY-NOT: int_function
8298
// CHECK-DECLARATIONS-ARRAY-NOT: fp_function

0 commit comments

Comments
 (0)