Merge pull request #26520 from jckarter/switch-loadable-after-address-only

SILGen: Emit bb args for shared loadable case bindings that come after address-only ones.

Author: jckarter

lib/SILGen/SILGenPattern.cpp

@@ -2341,7 +2341,7 @@ void PatternMatchEmission::initSharedCaseBlockDest(CaseStmt *caseBlock,
     // We don't pass address-only values in basic block arguments.
     SILType ty = SGF.getLoweredType(vd->getType());
     if (ty.isAddressOnly(SGF.F))
-      return;
+      continue;
     block->createPhiArgument(ty, ValueOwnershipKind::Owned, vd);
   }
 }

test/SILGen/switch_mixed_address_only_loadable.swift

@@ -0,0 +1,13 @@
+// RUN: %target-swift-emit-silgen %s
+
+// rdar://problem/53956564
+
+func foo<T>(x: Int, y: T, z: Int) {
+  switch (x, y, z) {
+  case (let xx, let yy, let zz), (let xx, let yy, let zz):
+    _ = xx
+    _ = yy
+    _ = zz
+    break
+  }
+}