Fold ConstraintSolver::coerceToRValue into TypeChecker::coerceToRValue() #10276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue() ConstraintSolver::coerceToRValue() missed a bunch of cases where we should be dealing with lvalues, e.g., tuples, "try" expressions, and so on. Extend TypeChecker::coerceToRValue() to deal with the expression type side-tables and ConstraintSolver::coerceToRValue() to it. Fixes rdar://problem/32700180, a crash-on-valid.
Between syntactic restrictions and later checks for spurious '&' expressions, we don't need to check for '&' expressions when coercing to an rvalue. Plus, 'inout' doesn't imply 'not lvalue', so we'd never get here.
DougGregor
force-pushed
the
coerce-to-rvalue
branch
from
ffe7290 to
511c245
Compare
DougGregor
changed the title
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fold
ConstraintSolver::coerceToRValue()intoTypeChecker::coerceToRValue()ConstraintSolver::coerceToRValue()missed a bunch of cases where weshould be dealing with lvalues, e.g., tuples, "try" expressions, and
so on. Extend
TypeChecker::coerceToRValue()to deal with theexpression type side-tables and
ConstraintSolver::coerceToRValue()toit.
Fixes rdar://problem/32700180, a crash-on-valid.