[4.0] Fold ConstraintSolver::coerceToRValue() into TypeChecker::coerceToRValue() #10288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue() ConstraintSolver::coerceToRValue() missed a bunch of cases where we should be dealing with lvalues, e.g., tuples, "try" expressions, and so on. Extend TypeChecker::coerceToRValue() to deal with the expression type side-tables and ConstraintSolver::coerceToRValue() to it. Fixes rdar://problem/32700180, a crash-on-valid.
|
@swift-ci please test |
|
@swift-ci test source-compatibility |
|
@swift-ci Please test source compatibility |
slavapestov
approved these changes
Jun 15, 2017
|
Source compatibility suite has yet to recover from the SDK update, so it's not providing signal here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The type checker failed to handle tuples containing lvalues (e.g., references to "var" properties in a class) along some paths, causing crashes in SILGen and (for asserts builds) AST verifier errors.
Scope: It's not clear that this ever worked, but seems fairly common. I think we've just made users suffer needlessly by getting this wrong.
Radar: rdar://problem/32700180
Risk: Low; re-use an established code path to fix the problems here rather than a poor duplication of it.
Testing: Tested example from radar, plus normal compiler qualification.