Skip to content

[4.0] Promote a bunch of Swift 3 compatibility access warnings to errors. #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2017
Merged

[4.0] Promote a bunch of Swift 3 compatibility access warnings to errors. #10325

merged 1 commit into from
Jun 17, 2017

Conversation

jrose-apple
Copy link
Contributor

@jrose-apple jrose-apple commented Jun 16, 2017 •
edited
Loading

  • Explanation: Swift 3.0.1 (or 3.0.2?) fixed a bunch of missed access control diagnostics in 3.0.0, but for compatibility reasons made them warnings instead. We should make them proper errors in Swift 4 mode.
  • Scope: Affects code that would have received access-control-related warnings under Swift 3.
  • Radar: rdar://problem/32825342
  • Reviewed by: @harlanhaskins, @CodaFi
  • Risk: Low. Does not affect Swift 3 mode, and "just" replaces warning diagnostics with errors in Swift 4 mode.
  • Testing: Added Swift 4 mode regression tests.

@jrose-apple
Promote a bunch of Swift 3 compatibility access warnings to errors. (s…
cef8889 
…wiftlang#10086)

This was done back in Swift 3.0.1 or 3.0.2. Let's finally make them
errors in Swift 4!

I also fixed up a number of '%error' entries in diagnostics that can
actually happen in invalid code. These are the ones that were already
present in the warnings.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@tkremenek tkremenek merged commit abc664b into swiftlang:swift-4.0-branch Jun 17, 2017
@jrose-apple jrose-apple deleted the 4.0-access-denied branch June 17, 2017 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @tkremenek