[4.0] [AST Verifier] Don't verify parsed function bodies in a type-checked AST. #10389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AST. Eliminates an AST verifier crash on reasonable ASTs where we ended up synthesizing the body for a function (e.g., from the Clang importer) that we don't actually need to type-check. Fixes rdar://problem/32774779. (cherry picked from commit d40e869)
|
@swift-ci please test |
jrose-apple
approved these changes
Jun 20, 2017
rudkx
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Eliminates an AST verifier crash on reasonable ASTs where we ended up
synthesizing the body for a function (e.g., from the Clang importer) that we don't actually need to type-check.
Scope: This is a fairly common source of AST verifier crashes in builds with assertions enabled, but otherwise has zero effect.
Radar: rdar://problem/32774779
Risk: Zero risk to customer builds; this code is disabled in non-assertions compilers.
Testing: Built the affected project with assertions enabled, plus of course normal compiler regression testing.