[4.0] Improve reporting of @objc inference issues from the Swift runtime #10528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Swift runtime issue reporting for @objc inference to include details about the declaration of the method (that is missing the @objc annotation) and a suggested fix-it. This changes the ABI of RuntimeErrorDetails, so we're also bumping the version.
• Explanation: Swift runtime issues for Obj-C implicit entrypoint are not pointing to the declaration where the @objc attribute needs to be added.
• Scope of Issue: Users who have bugs due to implicit Obj-C entrypoints might now easily find out where is the declaration that is missing the @objc attribute.
• Radar: rdar://problem/32933687
• Risk: Low. We're only touching the codepaths that are triggered when Swift generates a runtime issue.
• Testing: I verified that with the patch, LLDB sees the note properly (and the LLDB PR has a test for it).