[4.0] [CMake] iOS simulator should still build 32-bit by default. #10534
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Jun 23, 2017
jrose-apple
commented
- Explanation: The iOS simulator build was accidentally set to only build a 64-bit slice. Reactivate the 32-bit slice by adding "i386" back into the list of supported architectures.
- Scope: Affects all iOS simulator libraries (the stdlib and overlays, plus support libraries like StdlibUnittest)
- Radar: rdar://problem/32862833
- Reviewed by: @shahmishal
- Risk: Very low. This was a previously working and tested configuration.
- Testing: Verified locally that both slices were being built once again.
…g#10510) Accidentally deleted and never noticed because all of the package builds configure this explicitly.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.