Skip to content

Downgrade conditional compilation assignment error to a warning #10643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jun 27, 2017

To unblock certain projects that are using malformed flags, downgrade
this specific error to a warning for now.

rdar://33018039

@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 27, 2017

// cc @ddunbar @atrick

@swift-ci please smoke test and merge

@ddunbar
Copy link
Contributor

ddunbar commented Jun 27, 2017

Nice, that was fast!

To unblock certain projects that are using malformed flags, downgrade
this specific error to a warning for now.

rdar://33018039
@CodaFi CodaFi force-pushed the distant-early-warning branch from a9f7793 to f04c817 Compare June 28, 2017 00:00
@CodaFi
Copy link
Contributor Author

CodaFi commented Jun 28, 2017

@swift-ci please smoke test and merge

@atrick
Copy link
Contributor

atrick commented Jun 28, 2017

👍

@swift-ci swift-ci merged commit 53bdb90 into swiftlang:master Jun 28, 2017
@CodaFi CodaFi deleted the distant-early-warning branch June 28, 2017 00:20
jrose-apple pushed a commit to jrose-apple/swift that referenced this pull request Jul 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants