[4.0jun23][Clang importer/module printing] Correctly print NS_ERROR_ENUMs. #10651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since we stopped associating the top-level struct of an imported NS_ERROR_ENUM with the Clang enum declaration, we've been unable to print imported NS_ERROR_ENUMs. The module-printing infrastructure would drop them thinking they aren't imported declarations. This also affected NS_ERROR_ENUMs that were imported as members of another type, as well as other types imported as members. Fixes rdar://problem/32497693. (cherry picked from commit 6a26f5f)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Properly print imported
NS_ERROR_ENUMtypes in the module interface; they were getting dropped.Scope: Affects module interface printing.
Reviewer: @jrose-apple
Radar: rdar://problem/32497693
Risk: Very low; it's printing some declarations that were otherwise dropped.
Testing: Compiler regression tests; new tests; printing everything in the iOS SDK and manually inspecting the diffs.