Skip to content

[Gardening] Import the value of a subscript setter as owned #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 5, 2017

The translation from a bit to the specifiers exposed this instance
in the Clang importer where we hooked up a parameter as mutable
but never reflected that in the interface type.

A future patch requires that this parameter be immutable.

Depends on #10767

The translation from a bit to the specifiers exposed this instance
in the Clang importer where we hooked up a parameter as mutable
but never reflected that in the interface type.

A future patch requires that this parameter be immutable.
@CodaFi CodaFi requested a review from jrose-apple July 5, 2017 21:19
@CodaFi CodaFi changed the title Import the value of a subscript setter as owned [Gardening] Import the value of a subscript setter as owned Jul 5, 2017
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, that was probably copy/pasted from the self parameter way back when that was explicit.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 5, 2017

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 7763bad into swiftlang:master Jul 5, 2017
@CodaFi CodaFi deleted the lets-not-get-into-specifics branch July 6, 2017 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants