[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215) #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks decl options to ensure it can be applied to a parameter & handles no escape special case as it's not a type attribute unless in SIL mode
|
Did you mean to also add tests from the old PR? |
|
@gribozavr Sorry about that, should be sorted now. |
|
Tests pass now, merging. |
gribozavr
added a commit
that referenced
this pull request
Jan 26, 2016
[Parser] Fix-it for declaration attributes being applied to parameter types (SR-215)
|
Actually, no -- this caused a build failure: Reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #673 but reverted due to test failures. Test failures should be fixed in this PR. Original description as follows:
As described in SR-215, previously the fix-it was suggesting that declaration attributes applied to parameter types be moved to before the function
funcdeclaration itself.This pull request fixes this so that it is instead moved to before the parameter name.