Skip to content

[swift-4.0-branch][overlay] Add INRideOption #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2017
Merged

[swift-4.0-branch][overlay] Add INRideOption #10917

merged 1 commit into from
Jul 13, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 12, 2017

  • Explanation: Fixes backward compatibility for the code using INRideOption.usesMeteredFare
  • Scope of Issue: A property has different types in Swift 3 and Swift 4.
  • Risk: Minimal
  • Reviewed By: Willem Mattelaer
  • Testing: Automated test suite + a new test case
  • Directions for QA: N/A
  • Radar: rdar://problem/32935297

(cherry picked from commit 923468b)

[overlay] Add INRideOption
2ffbbd9 
<rdar://problem/32935297>

(cherry picked from commit 923468b)
@moiseev
Copy link
Contributor Author

moiseev commented Jul 12, 2017

Similar to #10903

@moiseev
Copy link
Contributor Author

moiseev commented Jul 12, 2017

@swift-ci Please test

@moiseev moiseev mentioned this pull request Jul 12, 2017
Merged
@moiseev moiseev merged commit fc7b3f2 into swiftlang:swift-4.0-branch Jul 13, 2017
@moiseev moiseev deleted the metered-fare-4 branch July 13, 2017 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moiseev