[4.0] Upgrade some deprecation warnings from Swift 3 to errors in Swift 4 #10920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of rdar://problem/28961650 .
Part of rdar://problem/28961650 .
Part of rdar://problem/28961650 .
…wift 4 error. Part of rdar://problem/28961650 .
…errors. Part of rdar://problem/28961650 .
…rrors in Swift 4.0. Fixes rdar://problem/28961650 .
|
@swift-ci Please test |
|
@swift-ci Please Test Source Compatibility |
|
Hm, I wonder if this should maybe go into swift-4.0-branch-2017-07-11 rather than swift-4.0-branch, since it's relatively safe from a code perspective but we may want more time to assess any downstream breakage? |
|
LGTM |
huonw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0 merge of #10908 .
Explanation: Some features were deprecated (with warnings) in 3.x versions, which we can switch to hard errors in 4.0.
Scope: This is source breaking, but only for things that have at least 6 months of warnings of deprecation and which we've explicitly decided we don't want, and several of them seem to have migration help.
Radar: rdar://problem/28961650
Risk: Low in terms of compiler crashes etc, since this just adds switches to choose between some pairs of
ERRORandWARNINGdiagnostic IDs. There's also relatively low risk of unacceptable source breakage, as we've been alerting people to our intentions to break for a while.Testing: CI testing, including a new test that explicitly checks that all of these remain warnings in Swift 3, and all are errors in Swift 4, as well as running the source compatibility suite.