Skip to content

[overlay] Add back INSetProfileInCarIntent.defaultProfile for compatibliity #11175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 25, 2017

rdar://problem/33457609

@moiseev moiseev changed the title "[overlay] Add back INSetProfileInCarIntent.defaultProfile for compatibliity [overlay] Add back INSetProfileInCarIntent.defaultProfile for compatibliity Jul 25, 2017
@moiseev
Copy link
Contributor Author

moiseev commented Jul 25, 2017

@swift-ci Please test

@@ -128,6 +128,11 @@ extension INSetProfileInCarIntent {
return __defaultProfile?.boolValue
}

@available(iOS, deprecated: 11.0, message: "Please use isDefaultProfile instead")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these deprecations really be based on deployment target and not Swift version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's going to apply to everything in the overlay, so maybe a separate commit!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrose-apple it is not that simple elsewhere in this file. Needs some extra thinking...

@moiseev moiseev force-pushed the missing-default-profile branch from 936a79c to 7569dc9 Compare July 25, 2017 22:26
@moiseev
Copy link
Contributor Author

moiseev commented Jul 25, 2017

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 936a79cbf2eee87f03000ad570b1db6db1e10d10
Test requested by - @moiseev

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 936a79cbf2eee87f03000ad570b1db6db1e10d10
Test requested by - @moiseev

@moiseev
Copy link
Contributor Author

moiseev commented Jul 26, 2017

@swift-ci Please test macOS platform

@moiseev moiseev merged commit ec3b7d5 into swiftlang:master Jul 26, 2017
@moiseev moiseev deleted the missing-default-profile branch July 26, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants