-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[overlay] Add back INSetProfileInCarIntent.defaultProfile for compatibliity #11175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
@@ -128,6 +128,11 @@ extension INSetProfileInCarIntent { | |||
return __defaultProfile?.boolValue | |||
} | |||
|
|||
@available(iOS, deprecated: 11.0, message: "Please use isDefaultProfile instead") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these deprecations really be based on deployment target and not Swift version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's going to apply to everything in the overlay, so maybe a separate commit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrose-apple it is not that simple elsewhere in this file. Needs some extra thinking...
…ibliity <rdar://problem/33457609>
936a79c
to
7569dc9
Compare
@swift-ci Please test |
Build failed |
Build failed |
@swift-ci Please test macOS platform |
rdar://problem/33457609