Reject member lookups that require bridging metatypes #11446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can only coerce metatypes covariantly but bridging always requires an unrelated metatype cast. When performing member lookup, especially unqualified member lookup, disregard static members from bridged types entirely. See SR-5670 and rdar://problem/33830526
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
|
CodaFi
changed the title
DougGregor
approved these changes
Aug 17, 2017
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can only coerce metatypes covariantly but bridging
always requires an unrelated metatype cast. When
performing member lookup, especially unqualified member
lookup, disregard static members from bridged types entirely.
Resolves SR-5670 and rdar://problem/33830526.
I have a hunch this might break things, stand by.