'open' classes within 'public' structs should be considered open. #11925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, our hack to give all open class vtable members public linkage at the LLVM level wasn't kicking in, and subclasses from other modules were getting link errors. rdar://problem/32885384
|
@swift-ci Please test |
slavapestov
approved these changes
Sep 19, 2017
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 19, 2017
…iftlang#11925) Without this, our hack to give all open class vtable members public linkage at the LLVM level wasn't kicking in, and subclasses from other modules were getting link errors. rdar://problem/32885384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, our hack to give all open class vtable members public linkage at the LLVM level wasn't kicking in, and subclasses from other modules were getting link errors.
rdar://problem/32885384