Requirement environment: adopt the conformance's generic signature when we can. #12204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
DougGregor
force-pushed
the
req-sig-short-circuit
branch
from
12fb3e6 to
073d757
Compare
…en we can. Noticed by Slava: when the requirement is non-generic, the requirement signature's generic signature is always going to be the same as the conformance declaration context's generic signature, so use that immediately. This eliminates a large number of generic signature builders created due to requirement signatures (e.g., from 4893 -> 569 when measured against the standard library work for SE-0157). Short-circuit build of requirement environment. This is all Slava and it’s magnificent. FIXUP for “the Slava change”
DougGregor
force-pushed
the
req-sig-short-circuit
branch
from
073d757 to
45ef8cf
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed by Slava: when the requirement is non-generic, the requirement
signature's generic signature is always going to be the same as the
conformance declaration context's generic signature, so use that immediately.
This eliminates a large number of generic signature builders created due to
requirement signatures (e.g., from 4893 -> 569 when measured against
the standard library work for SE-0157).