[runtime] Clean up symbol exports in casting and class introspection. #13005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macos |
slavapestov
reviewed
Nov 20, 2017
| @_inlineable // FIXME(sil-serialize-all) | ||
| @_versioned // FIXME(sil-serialize-all) | ||
| @_silgen_name("swift_getTypeByName") | ||
| @_silgen_name("") |
There was a problem hiding this comment.
What does it mean to have an empty string literal here?
There was a problem hiding this comment.
It means the function gets the same symbol visibility treatment as ordinary @_silgen_name (i.e. internal functions get C-visible hidden symbols), but the mangled name of the function is unchanged. This syntax is a temporary hack and ought to be replaced someday.
The goal is that Swift functions that merely happen to be implemented in C today should have Swift-mangled symbol names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.