Some small constraint system cleanups. #13197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vored types. This allows us to eliminate some special casing around things like parens, and allows the code to work for other code involving expressions that are semantically neutral.
These purportedly mark that we should stop attempting fixes for a given constraint, but in fact the only code creating these is clearly unreachable so these serve no purpose.
…tionals. Only record the fixes when they have made the solution to this point successful.
It's probably harmless to record the ones for failures which later cause us to back out in the solver, but it means we cannot easily set breakpoints in places like recordFix and stop only in the places where the fixes actually cause the solution to make progress.
|
@swift-ci Please smoke test |
rudkx
changed the title
|
https://ci.swift.org/job/oss-swift_tools-R_stdlib-RD_test-simulator/699/ utils/build-script --preset=buildbot,tools=R,stdlib=RD install_destdir="${WORKSPACE}/install" installable_package="${SWIFT_INSTALLABLE_PACKAGE}" |
|
I disabled the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.