[Sema] Translate names in unused result warnings of implicit functions #13622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of warning about an unused result of a call to an implicit function '__derived_enum_equals' or '__derived_struct_equals' use its user-facing name '=='.
|
@swift-ci Please smoke test |
|
LGTM. I'm curious why these have a special name to begin with, though? Also, you'll need to run full tests to merge at the moment, not just smoke tests. |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, an unused call to synthesized
==of enums and structs warns about an unused call to the functions__derived_enum_equalsand__derived_struct_equals.Solution
This PR adds a special case to translate these calls back to the call to the operator
==.Example
I just found this bug and it is not tracked by an SR yet.