[Demangle] Add back isSwiftSymbol() entry point for null-terminated strings #13857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trings. This particular API can be safely used with a null-terminated string, and is used by some clients (e.g., LLDB), so add back a "const char *" variant that safely accesses a null-terminated string.
|
@swift-ci please smoke test and merge |
huonw
reviewed
Jan 30, 2018
| @@ -139,6 +139,11 @@ bool swift::Demangle::isSwiftSymbol(llvm::StringRef mangledName) { | |||
| return getManglingPrefixLength(mangledName) != 0; | |||
| } | |||
|
|
|||
| bool swift::Demangle::isSwiftSymbol(const char *mangledName) { | |||
| StringRef mangledNameRef(mangledName, 4); | |||
There was a problem hiding this comment.
What happens if a mangled name is shorter than 4 characters? I happened to notice it and "fixed" it in #14249 but now that I see you introduced this behaviour so recently, I'm now wondering if that was a mistake...
There was a problem hiding this comment.
Thanks for fixing; I think it was sloppiness on my part when I re-introduced an old API that already had these issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular API can be safely used with a null-terminated string,
and is used by some clients (e.g., LLDB), so add back a "const char *"
variant that safely accesses a null-terminated string.