Skip to content

Remove redundant assertion, which is already checked at lower level. #13980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2018

Conversation

davidungar
Copy link
Contributor

No description provided.

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@jrose-apple
Copy link
Contributor

I think we've reached the point where you don't need my review on this sort of thing. It's in code you've already touched and it should be a "no-functionality-change" commit. (That said, it's not an unreasonable principle to say every PR should have a second pair of eyes.)

@davidungar davidungar requested review from graydon and removed request for jrose-apple January 17, 2018 02:02
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test linux platform

Copy link
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess? I don't see the harm in redundant asserts, but if it's truly checked elsewhere (where?) then sure.

@davidungar davidungar merged commit adce82d into swiftlang:master Jan 17, 2018
@davidungar davidungar deleted the PR-18-2 branch May 16, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants