Skip to content

ClangImporter: Update Swift for changes in clang (PCH + Modules issues) #14759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2018
Merged

ClangImporter: Update Swift for changes in clang (PCH + Modules issues) #14759

merged 1 commit into from
Feb 21, 2018

Conversation

bcardosolopes
Copy link
Contributor

This sets the NeededByPCHOrCompilationUsesPCH language option when
emitting a brigding PCH.

rdar://problem/35056912
rdar://problem/30384801

Initial patch by Adrian Prantl

This sets the NeededByPCHOrCompilationUsesPCH language option when
emitting a brigding PCH.

rdar://problem/35056912
rdar://problem/30384801

Initial patch by Adrian Prantl
@bcardosolopes
Copy link
Contributor Author

Please test with following PR:
apple/swift-clang#162

@swift-ci Please test

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though some day you'll have to explain to me why Clang doesn't just always have this on, or at least on by default.

@bcardosolopes bcardosolopes merged commit 3152267 into swiftlang:swift-4.1-branch Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants