Skip to content

Last SILGenApply Cleanups #14865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2018
Merged

Last SILGenApply Cleanups #14865

merged 2 commits into from
Feb 27, 2018

Conversation

gottesmm
Copy link
Contributor

This is the last PR in a series of PRs to cleanup SILGenApply a bit. This PR does two more things:

  1. It makes the indentation of classes throughout the whole file.
  2. It centralizes all "top level entry points" at the bottom of the file. These top level entry points are SILGenFunction interface to SILGenApply. Previously they were strewn randomly throughout the file (with a large amount at the bottom). This just makes the file more consistent.

@gottesmm
[silgen] In SILGenApply.cpp, consistently indent classes in LLVM style.
1de4cc0 
Some of the classes in this file were using LLVM style for long classes, i.e.:

```
namespace {
class Foo {
  ... long class ...
};
} // end anonymous namespace
```

Other places, we were adding a level of indentation, i.e.:

```
namespace {
  class Foo {
    ... long class ...
  };
} // end anonymous namespace
```

This PR just standardizes the classes in this file that follow the later style,
to instead follow the former style.
@gottesmm
[silgenapply] Centralize top level SILGenFunction entrypoints (i.e. S…
56556b7 
…ILGenFunction entrypoints) in 1 section of SILGenApply.cpp.
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit f0549bb into swiftlang:master Feb 27, 2018
@gottesmm gottesmm deleted the last_silgenapply_cleanups branch February 27, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gottesmm @swift-ci