[Parser][SE-0034] Replace line directive #line with #setline #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduan
changed the title
|
@swift-ci please test |
| @@ -291,7 +292,7 @@ ParserStatus Parser::parseBraceItems(SmallVectorImpl<ASTNode> &Entries, | |||
| PreviousHadSemi = false; | |||
| if (isStartOfDecl() | |||
| && Tok.isNot(tok::pound_if) | |||
| && Tok.isNot(tok::pound_line)) { | |||
| && Tok.isNot(tok::pound_setline)) { | |||
There was a problem hiding this comment.
Minor nitpick, you can use Tok.isNot(x, y) here, though it looks like a preexisting issue.
|
Overall, the patch looks great to me, thanks! Random other question: does gyb or any other tool produce these markers? If so, it should be updated to use the new syntax. |
|
@lattner Thanks for reminding me of gyb. There are a couple of default argument and documentation set to |
|
gyb updated. Tests are passing locally. Can't wait to be able to trigger CI testing myself :) |
|
Awesome, nice job, please commit! |
dduan
added a commit
that referenced
this pull request
Mar 2, 2016
[Parser][SE-0034] Replace line directive #line with #setline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Replace line directive
#linewith#setline. This change was proposed in SE-0034.Resolved bug number: (SR-840)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.