Skip to content

No need to repeat the same test twice #15451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Conversation

onevcat
Copy link
Contributor

@onevcat onevcat commented Mar 23, 2018

It might be due to a historical reason before bridging works as it does now. There should be no need to repeat the same assertion twice here.

What's in this pull request?

Removing the same expectation assertion in DictionLiteral test for stdlib. It's an improvement of the test so there is no external link.

It might be due to a historical reason before bridging works as it does now. There should be no need to repeat the same assertion twice here.
@onevcat
Copy link
Contributor Author

onevcat commented Mar 23, 2018

@swift-ci Please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Mar 23, 2018

Thanks.

@swift-ci please smoke test and merge

@onevcat
Copy link
Contributor Author

onevcat commented Mar 25, 2018

@CodaFi I am not sure why but it seems that tests under Linux timeout. Is it possible to restart a test for it?

Thanks.

@CodaFi
Copy link
Contributor

CodaFi commented Mar 25, 2018

@swift-ci please smoke test Linux platform

@CodaFi
Copy link
Contributor

CodaFi commented Mar 25, 2018

⛵️

@CodaFi CodaFi merged commit f79aca8 into swiftlang:master Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants