Diagnose unavailable getters and setters #15864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a "no functionality change" commit because this isn't /invoked/ on accessors yet; that's the next commit. I wanted to separate out the mechanical part, though.
This handles the case where one accessor is /unavailable/ but not the other. This is rarer than deprecation (handled in b0e12f4), but could still happen. Finishes rdar://problem/18633725 / SR-7201.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
devincoughlin
approved these changes
Apr 12, 2018
| @@ -1,4 +1,4 @@ | |||
| // RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -typecheck -verify -I %S/Inputs/custom-modules %s | |||
| // RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -typecheck -verify -I %S/Inputs/custom-modules %s -verify-ignore-unknown | |||
There was a problem hiding this comment.
Where do the unknown locations come from? Is that for notes on the imported accessors?
There was a problem hiding this comment.
Yep. I'm not super happy about that but it seems unrelated to the purpose of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where one accessor is unavailable but not the other. This is rarer than deprecation (handled in #15102), but could still happen.
Finishes rdar://problem/18633725 / SR-7201.