AST: Exclude noncanonical params from GenericSignature::enumeratePairedRequirements.
#15960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Apr 16, 2018
lib/AST/GenericSignature.cpp
Outdated
| // Otherwise, the generic parameter is concrete. | ||
| gp = req.getFirstType()->getAs<GenericTypeParamType>(); | ||
| if (!gp) continue; | ||
| } | ||
|
|
||
| unsigned index = GenericParamKey(gp).findIndexIn(genericParams); | ||
| genericParamsAreConcrete[index] = true; |
There was a problem hiding this comment.
genericParamsAreConcrete is now a misnomer; genericParamIsNonCanonical, perhaps?
…redRequirements`. Fixes a bug where having two generic params same-typed together would lead to crashes in IRGen, and maybe other places, that only expect to deal with canonical params.
jckarter
force-pushed
the
enumerate-only-canonical-paired-requirements
branch
from
bc38003 to
b842686
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where having two generic params same-typed together would lead to crashes in IRGen, and maybe other places, that only expect to deal with canonical params.