Fix symbolic references #16086
Merged
Fix symbolic references #16086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we could only handle symbolic references at the top level, but this is insufficient; for example, you can have a nested type X.Y where X is defined in the current translation unit and Y is defined in an extension of X in a different translation unit. In this case, X.Y mangles as a tree where the child contains a symbolic reference to X. Handle this by adding a new form of Demangle::mangleNode() which takes a callback for resolving symbolic references. Fixes <rdar://problem/39613190>.
|
@swift-ci Please smoke test |
|
Thanks Slava! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/39613190.