[Runtime] Teach BridgeObjectBox::retain() not to drop the "not native" bit. #16108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" bit. The "not native" bit in a BridgeObject is important, because it tells us when we need to go through the Objective-C -retain method vs. swift_retain. Losing the bit means that swift_retain() will stomp on some memory within an Objective-C object, thinking its the inline reference count. Co-debugged with Arnold, who then found where this bit was getting dropped. Fixes rdar://problem/39629937.
DougGregor
force-pushed
the
runtime-bridge-object-box
branch
from
7113456 to
d755b38
Compare
|
@swift-ci please smoke test and merge |
aschwaighofer
approved these changes
Apr 23, 2018
|
This is very similar to the swift_unknownRetain bug. We really should make changes to the runtime that define away this problem. Or at least makes it much easier to catch it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "not native" bit in a BridgeObject is important, because it tells
us when we need to go through the Objective-C -retain method
vs. swift_retain. Losing the bit means that swift_retain() will stomp
on some memory within an Objective-C object, thinking its the inline
reference count.
Co-debugged with Arnold, who then found where this bit was getting dropped.
Fixes rdar://problem/39629937.