[AST] Adopt SubstitutionMap as the storage mechanism for substitutions #16268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow substitution maps to be serialized directly (via an ID), writing out the replacement types and conformances as appropriate. This is a more efficient form of serialization than the current SubstitutionList approach, because it maintains uniqueness of substitution maps within a module file, and is a step toward eliminating SubstitutionList entirely.
Convert NameAliasType’s internal representation from tail-allocating an array of Substitutions (to be treated as a SubstitutionList) to store a single SubstitutionMap. Serialize using that SubstitutionMap.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start adopting
SubstitutionMapas the storage mechanism for substitutions, replacing instances ofSubstitutionListwithin AST nodes (and some APIs) with the uniqued,ASTContext-allocatedSubstitutionMap. Specifically:SubstitutionMap(de-)serializable, so we can easily embed a substitution map in the on-disk layout of an AST nodeNameAliasTypeover to storing aSubstitutionMap; eliminate correspondingSubstitutionListAPIs.