Remove __consuming from Code Completion #17096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the UserInaccessible bit to remove __consuming from code completion until we commit to a real keyword. rdar://40828289
CodaFi
force-pushed
the
all-consuming-fire
branch
from
89464fa to
df698d2
Compare
|
@swift-ci please smoke test and merge |
benlangmuir
reviewed
Jun 11, 2018
| // FIXME: __consuming should not appear in CodeCompletion until it is | ||
| // finalized in a language proposal. | ||
| if (Name == "__consuming") | ||
| return; |
There was a problem hiding this comment.
We should form the DeclAttributeKind and use DeclAttribute::isUserInaccessible() instead of handling __consuming explicitly. I thought we already did that, but it looks like we only handle it on attribute completion right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the UserInaccessible bit and remove __consuming from code
completion until we commit to a real keyword.
rdar://40828289