[DebugInfo] Don't record that the standard library imports itself #17226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Can you add a testcase (presumably with a CHECK-NOT: line)? |
This causes problems for cross-compilation -parse-stdlib tests that emit debug info. At the moment we have zero of those, but we're trying to add one. Also, don't try to load new modules when recording imports. (This isn't harmful, just inefficient.)
|
Passed full testing already, so just smoke testing now for the new test Adrian asked for. @swift-ci Please smoke test |
adrian-prantl
approved these changes
Jun 15, 2018
| // RUN: %FileCheck -check-prefix=NEGATIVE %s < %t.ll | ||
|
|
||
| // RUN: %target-swift-frontend -c -parse-stdlib -module-name NotTheStdlib %s -I %t -g -o %t.o | ||
| // RUN: %llvm-dwarfdump -a %t.o > %t.dump |
There was a problem hiding this comment.
Just checking the IR would have been sufficient — we already check that a DIImportedEntity(DIModule) gets lowered correctly elsewhere, but this is fine, too.
There was a problem hiding this comment.
Ah, right. I copied from the other test and just updated everything.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes problems for cross-compilation -parse-stdlib tests that emit debug info. At the moment we have zero of those, but we're trying to add one (#17087).
Also, don't try to load new modules when recording imports. (This isn't harmful, just inefficient.)