[4.2] stdlib: Remove Collection.randomElement customization point. #17639
+30
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
As proposed and accepted in amendment swiftlang/swift-evolution#863. rdar://problem/41067949
jckarter
force-pushed
the
remove-randomelement-customization-point-4.2
branch
from
af415f5 to
c833d85
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Build failed |
|
Build failed |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Implements an accepted amendment to SE-202, removing a customization point from Collection that could cause forward compatibility issues with move-only types.
Scope: Small semantics break that would ideally be implemented before Swift 4.2 is finalized.
Issue: rdar://problem/41067949
Risk: Low, removes a protocol customization point with a default implementation
Testing: Swift CI, compatibility suite
Reviewed by: @airspeedswift