[4.2] migrator: handle member variables change to global ones. rdar://41658300 #17672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: By manually experimenting with APIs, we found a few cases of nested variables in Xcode 9 change to global variables in Xcode 10. Since the pattern migrator used to handle is only the opposite direction, we need to update the swift-api-digester and the migrator to detect and handle this category of changes.
Scope of Issue: Swift 4.2 migrator
Risk: Very Low
Reviewed by: Nathan Hawes
Testing: Unit tests added.
Radar: rdar://41658300