Skip to content

[Parse] Drop Swift3 support for misc diagnostics #17787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 6, 2018

Several diagnostics were warning in Swift3, but errors in Swift4+

Related #10908
CC: @huonw

@rintaro
Copy link
Member Author

rintaro commented Jul 6, 2018

@swift-ci Please smoke test

Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Several diagnostics were warnings in Swift3, but errors in Swift4+

Related: swiftlang#10908
@rintaro rintaro force-pushed the parse-miscdiag-drop3 branch from 4e844a5 to d9746f2 Compare July 7, 2018 14:29
@rintaro
Copy link
Member Author

rintaro commented Jul 7, 2018

@swift-ci Please smoke test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Jul 25, 2018

@swift-ci Please smoke test

@rintaro rintaro merged commit 5058ec9 into swiftlang:master Jul 25, 2018
@rintaro rintaro deleted the parse-miscdiag-drop3 branch July 25, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants