Sema: Fix crash with UnresolvedType in coerceExistential() [4.2] #17871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <rdar://problem/34357545>.
|
@swift-ci Please test |
|
@xedin Do you mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Long-standing crash-on-invalid in diagnostics.
Origination: Probably there for a long time.
Scope of the issue: Reported several times.
Risk: Very low, this just adds some additional logic to a diagnostic path that only runs when we would have already crashed.
Tested: New test case added.
Reviewed by: @xedin
Radar: Fixes rdar://problem/34357545.