Skip to content

[test] Stop a test relying on inconsistent formatting of an error message. #18057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Jul 18, 2018

Fixes rdar://problem/42351773.

@huonw
Copy link
Contributor Author

huonw commented Jul 18, 2018

@swift-ci please smoke test and merge

@jrose-apple
Copy link
Contributor

You could use expected-error {{}} if you didn't want to change the test. Or just drop -verify altogether and use not.

@huonw
Copy link
Contributor Author

huonw commented Jul 18, 2018

I want to be specifically testing that the T type is the expected one inside the extension, and the error message was the first way I thought of doing that, but just writing the type seems better.

@huonw
Copy link
Contributor Author

huonw commented Jul 19, 2018

@swift-ci please smoke test Linux

@huonw huonw merged commit 7c088be into swiftlang:master Jul 19, 2018
@huonw huonw deleted the sr8240 branch July 19, 2018 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants