[stdlib] Work-around incorrect name resolution with conditional BidirectionalCollections. #18066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionalCollections. If a type conditionally conforms to BidirectionalCollection, suffix's (and the others) use of `index` ends up dispatching through `Collection.index` seemingly because it is a protocol requirement. The intended function is BidirectionalCollection's overloaded `index` (which _isn't_ connected to a protocol requirement), which is called for non-conditional conformances. As such, this is a work-around to stop code crashing. Noticed in SR-8022, rdar://problem/41216424.
|
@swift-ci please smoke test |
moiseev
approved these changes
Jul 19, 2018
This was referenced Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a type conditionally conforms to BidirectionalCollection, suffix's (and the
others) use of
indexends up dispatching throughCollection.indexseeminglybecause it is a protocol requirement. The intended function is
BidirectionalCollection's overloaded
index(which isn't connected to aprotocol requirement), which is called for non-conditional conformances. As
such, this is a work-around to stop code crashing.
Noticed in SR-8022, rdar://problem/41216424.