[IRGen] Fix 32-bit ARM extra inhabitant logic #18225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test platform |
rjmccall
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
Oops, thanks.
I would really like to completely eliminate the possibility of this kind of bug by having a target-assumptions database that exhaustively generates both System.h and the initialization code in SwiftTargetInfo.cpp. Do you have any interest in working on that? I think it's actually a good match for TableGen for once.
|
Build failed |
|
@swift-ci please test |
|
Hi @rjmccall – Do you have a bug tracking the TableGen idea? I'd be happy to follow it. Otherwise, I don't see myself having the time to work on that in the foreseeable future, nor do I see it blocking my work. |
|
Just thought I'd ask. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts:
89768cb
06b566f