Skip to content

[string] Internalize many faux-testable declarations #18456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

milseman
Copy link
Member

@milseman milseman commented Aug 1, 2018

No description provided.

Create a _StringRepresentation struct to standardize internal testing
on. Internalize much of _StringGuts, except for some SPI hacks, and
update tests to use _StringRepresentation.
@milseman
Copy link
Member Author

milseman commented Aug 2, 2018

@swift-ci please test and merge

@milseman
Copy link
Member Author

milseman commented Aug 2, 2018

@swift-ci please test

@milseman
Copy link
Member Author

milseman commented Aug 2, 2018

@swift-ci please test and merge

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2018

Build failed
Swift Test Linux Platform
Git Sha - ba6158d

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2018

Build failed
Swift Test OS X Platform
Git Sha - ba6158d

@milseman
Copy link
Member Author

milseman commented Aug 2, 2018

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8a70bebf881b07acf852fd1b24bedd23ab2ad6cf

@swift-ci
Copy link
Contributor

swift-ci commented Aug 2, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8a70bebf881b07acf852fd1b24bedd23ab2ad6cf

@milseman milseman merged commit b06c636 into swiftlang:master Aug 2, 2018
@milseman milseman deleted the internalable branch August 2, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants