swift-api-digester: add a new flag to indicate whether the tool is checking ABI stability. #18707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
reviewed
Aug 14, 2018
lib/AST/Type.cpp
Outdated
| @@ -4137,3 +4137,14 @@ Type TypeBase::openAnyExistentialType(ArchetypeType *&opened) { | |||
| opened = ArchetypeType::getOpened(this); | |||
| return opened; | |||
| } | |||
|
|
|||
| Requirement Requirement::getCanonicalRequirement() const { | |||
There was a problem hiding this comment.
I suggest just putting this in the ABI diff tool. If we end up needing it again we can move it to the class.
…ecking ABI stability. When this flag turns on, all type nodes and generic signatures are canonicalized.
nkcsgexi
force-pushed
the
abi-checking-flag
branch
from
7d1fb83 to
524dfa2
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this flag turns on, all type nodes and generic signatures are canonicalized.