[SR-7984] Constraint to concrete type using : should offer a fixit #18734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Kenta! But I'm not sure if we want the fix-it directly on the error, as opposed to on a note that explains what it would do instead. That'd be something like "use '==' to require 'T' to be 'Int'". |
|
And if you want to be really fancy, don't offer the fixit if the subject type is a GenericTypeParamType, unless you're in an extension. |
|
Superseded by #22152. Thanks for your efforts here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fixit for constraint to concrete type using
:.Resolves SR-7984.