Skip to content

[silgen] Change SILGenApply to use destructure, eliminating copies at… #18866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

… -Onone, and simplifying code.

rdar://43493020

@gottesmm gottesmm requested review from jckarter and rjmccall August 21, 2018 02:06
@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7f8a6623e86a96bd7ae06b1943212fe14c20d89d

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7f8a6623e86a96bd7ae06b1943212fe14c20d89d

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

… -Onone, and simplifying code.

rdar://43493020
@gottesmm gottesmm force-pushed the pr-ea1576522013552d8aeaf8f730669e85471ffa20 branch from 7f8a662 to 3f13aa2 Compare August 21, 2018 03:54
@gottesmm
Copy link
Contributor Author

I forgot locally a using declaration. Did a force push to fix the issue. Nothing else has changed.

@gottesmm
Copy link
Contributor Author

@swift-ci test

2 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3f13aa2

@gottesmm gottesmm merged commit 3b2c55f into swiftlang:master Aug 21, 2018
@gottesmm gottesmm deleted the pr-ea1576522013552d8aeaf8f730669e85471ffa20 branch August 21, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants